Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up Github Actions #2

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Set up Github Actions #2

merged 5 commits into from
Nov 21, 2024

Conversation

pantheredeye
Copy link
Owner

Set up Lint and Test for push/PR to master

Disabled tests until existing tests can be updated and successfully pass.
@pantheredeye
Copy link
Owner Author

@virtuoushub added this simple github action to lint on push/pr to master. Please suggest improvements/changes. This is the first time I have set up github actions, so any suggestions are welcome. I disabled testing for now.

@pantheredeye
Copy link
Owner Author

pantheredeye commented Nov 21, 2024

👀 watching the cache step in Setup Node step - currently it reports yarn cache is not found. this feels like an issue with the workflow itself. If it happens on the next run, then i'll tinker with it some more.

@pantheredeye pantheredeye merged commit 7b68a43 into master Nov 21, 2024
1 check passed
@pantheredeye pantheredeye deleted the bbb-github-actions branch November 21, 2024 16:30
@virtuoushub
Copy link
Contributor

@virtuoushub added this simple github action to lint on push/pr to master. Please suggest improvements/changes. This is the first time I have set up github actions, so any suggestions are welcome. I disabled testing for now.

lgtm overall - biggest nitpick I have is we might want to consider having the node and yarn version defined somewhere other than the GitHub action yml file and somehow configured to be read in that yml file, so there is a single source of truth for it (e.g. .nvm, package.json, etc.)

this is more of a nice to have however

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants