Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linting config to example_settings.json #984

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Conversation

egibs
Copy link
Contributor

@egibs egibs commented Nov 30, 2023

Background

Similar to #981, this PR mirrors the make lint configuration in example_settings.json which are then applied to the Workspace when make vscode-config is run.

This PR also introduces a .bandit and .pylintrc file to make the configuration more concise.

Changes

  • Adds make lint configuration to example_settings.json
  • Cleans up make lint using new configuration files

Testing

  • I tested this locally and the linting settings took effect after running make vscode-config

@egibs egibs requested review from a team November 30, 2023 23:28
@egibs egibs force-pushed the egibs-add-lint-config branch from 3254989 to e0e360b Compare November 30, 2023 23:30
@egibs egibs enabled auto-merge (squash) November 30, 2023 23:31
@egibs egibs merged commit c25a5ab into main Nov 30, 2023
1 check passed
@egibs egibs deleted the egibs-add-lint-config branch November 30, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants