Update GitHub Data Model to display admin-add events instead of UNKNOWN_ROLE #979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
GitHub's audit logs don't explicitly define an admin role and instead offers a few events that indicate admin permissions were assigned to a user (or at least when an attempt is made).
Originally, the data model only accounted for
team.promote_maintainer
, but there are two additional events that indicate admin permissions are being assigned or attempting to be assigned (at least at an organization level).This PR adds the additional events and returns the event name rather than
<UNKNOWN_ROLE>
when these events are encountered. Worst case, the data model falls back to<UNKNOWN_ADMIN_ROLE>
.Changes
Testing
make fmt; make lint; make test