Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout repository with GITHUB_TOKEN #977

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Conversation

egibs
Copy link
Contributor

@egibs egibs commented Nov 28, 2023

Background

A bug was reported with the sync-from-upstream Workflow which prevented the Workflow from running to completion with this error:

243 ! [remote rejected] sync_upstream_v3.25.0 -> sync_upstream_v3.25.0 (refusing to allow a GitHub App to create or update workflow `.github/workflows/lint-test.yml` without `workflows` permission)

The root cause was that we were not cloning the panther-analysis repository with the correct PAT so the Workflow did not have the correct permissions. This PR resolves the permissions issue (at least as far as using the correct PAT is concerned -- the PAT itself still need the correct scopes which were the workflow scopes in this particular case).

Changes

  • Checks out the panther-analysis repository with the same GITHUB_TOKEN PAT used elsewhere by the Workflow.

Testing

  • @nkulig tested this fix and was able to run the Workflow as expected

@egibs egibs requested review from a team November 28, 2023 17:09
@egibs egibs enabled auto-merge (squash) November 28, 2023 17:17
@egibs egibs merged commit d201e9e into main Nov 28, 2023
3 checks passed
@egibs egibs deleted the egibs-add-token-to-sync-checkout branch November 28, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants