Update CRYPTO_MINING_DOMAINS IOCs; add two additional tests #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egibs
commented
Nov 27, 2023
| CRYPTO_MINING_DOMAINS = { | ||
| "monerohash.com", |
There was a problem hiding this comment.
I also sorted this list alphabetically.
egibs
commented
Nov 27, 2023
| @@ -90,77 +90,262 @@ | |||
| "${::-j", # example: ${${::-j}${::-n}di:${::-l}d${::-a}p://example.com:1234/callback} | |||
| } | |||
|
|
|||
| # Sources: | |||
There was a problem hiding this comment.
I don't know where the original entries were sourced from, but I added the references to where I was sourcing the new entries from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This PR expands the set of
CRYPTO_MINING_DOMAINSwith many additional domains. To ensure correct support for subdomain-based IOCs, I also added two additional tests.Changes
CRYPTO_MINING_DOMAINSsetTesting
make fmt; make lint; make test