Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --generate-notes for release creation #960

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

egibs
Copy link
Contributor

@egibs egibs commented Nov 21, 2023

Background

Since we don't create a tag locally, we cannot use --notes-from-tag. This PR instead uses --generate-notes to handle all of the generation for the release.

--generate-notes               Automatically generate title and notes for the release

Changes

  • Uses --generate-notes rather than --notes-from-tag for release creation

Testing

  • I tested this locally in a separate repository and it worked as expected

@egibs egibs requested a review from a team November 21, 2023 19:51
@egibs egibs changed the title Egibs update release workflow Use --generate-notes for release creation Nov 21, 2023
@egibs egibs enabled auto-merge (squash) November 21, 2023 19:52
@egibs egibs merged commit 1e33659 into main Nov 21, 2023
3 checks passed
@egibs egibs deleted the egibs-update-release-workflow branch November 21, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants