Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded Microsoft365.Exchange.External.Forwarding to work with ForwardingAddress property #909

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

ben-githubs
Copy link
Contributor

Background

A customer noted that the Microsoft365.Exchange.External.Forwarding detection doesn't alert when the property ForwardingAddress is used. I added this property to the detection code.

Changes

  • Added a check for ForwardingAddress to Microsoft365.Exchange.External.Forwarding.
  • Added a unit test case for the above condition.

Testing

  • Ran make test.

@ben-githubs ben-githubs requested a review from a team October 24, 2023 19:41
@darwayne darwayne requested a review from arielkr256 October 24, 2023 20:07
Copy link
Contributor

@arielkr256 arielkr256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. got some linter fixes on other rules for free

@arielkr256 arielkr256 merged commit 85ace84 into master Oct 25, 2023
1 check passed
@arielkr256 arielkr256 deleted the ben/edit/ms_email_forward branch October 25, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants