Aws system location hb #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd make both of these INFO sev. Additionally the threshold behavior would be to not alert unless someone repeats the same action X times since the title being used for dedup has the useridentity, action, and account. If the intention was to alert if someone performs any of the listed actions X times, we'd need a custom dedup string excluding the action. |
|
This PR contains duplicate code to #642 |
|
Please move rules/aws_cloudtrail_rules/aws_system_discovery_location.py to #642 and close |
Close this PR or the other one? |
edyesed
suggested changes
Feb 8, 2023
arielkr256
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Added new ODIN detection for MITRE system location discovery.