Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THREAT-427: Fix 'check-deprecated' Script #1452

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

THREAT-427: Fix 'check-deprecated' Script #1452

wants to merge 1 commit into from

Conversation

ben-githubs
Copy link
Contributor

Background

Our check-deprecated script was failing to work properly in cases where a space was present in the query name. We observed this behaviour in our own PRs, and customers have also reported it.

Changes

  • Adjusted the regex used to scan gif diffs for removed items

Testing

  • Tested new regex pattern against all files in repo, and confirmed that all RuleIDs, PolicyIDs, and Query Names match

@ben-githubs ben-githubs requested a review from a team as a code owner December 17, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ben-githubs