AWS CloudWatch Log Resource Policy Confused Deputy Protection #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This policy ensures that AWS CloudWatch Log Resource Policies with service principals contain conditions to prevent cross-service confused deputy issues. Without these conditions (such as aws:SourceArn, aws:SourceAccount, aws:SourceOrgID, or aws:SourceOrgPaths), attackers may be able to exploit the resource policy to gain unauthorized access or misuse the service.
Changes
Added a new policy, AWS.CloudWatchLog.ConfusedDeputyProtection, to validate that CloudWatch Log Resource Policies containing service principals include at least one of the required conditions to mitigate the risk of confused deputy attacks.
Testing
Log Policy Without Required Conditions: Tests a policy with a service principal but no conditions (expected to fail).
Log Policy With Required Conditions: Tests a policy with a service principal and valid conditions (expected to pass).
Log Policy Without Service Principal: Tests a policy without a service principal (expected to pass).