Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Email Regex #1440

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Update Email Regex #1440

merged 5 commits into from
Dec 5, 2024

Conversation

arielkr256
Copy link
Contributor

Background

Fix for #1435

Changes

  • update email regex to properly identify email addresses

Testing

  • updated unit tests

@arielkr256 arielkr256 requested a review from a team as a code owner December 2, 2024 20:49
@arielkr256 arielkr256 added the bug Something isn't working label Dec 2, 2024
@ben-githubs
Copy link
Contributor

Do you think it's worth moving this regex check into a helper? (Seems like it could be useful in other rules, plus then we can add proper unit tests for the pattern, too)

@arielkr256 arielkr256 enabled auto-merge (squash) December 5, 2024 15:34
@arielkr256 arielkr256 disabled auto-merge December 5, 2024 17:17
@arielkr256 arielkr256 merged commit 2ffb95d into develop Dec 5, 2024
6 checks passed
@arielkr256 arielkr256 deleted the fix-issue-1435 branch December 5, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-githubs ben-githubs ben-githubs approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arielkr256 @ben-githubs