Refactor panther_azuresignin_helpers.actor_user
to use imported deep_get
#1422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This function is called from within the
Azure.Signin
data model code. Data models don't operate on a full Panther Event obejct, but instead get passed an immutable dict, which doesn't have adeep_get
function as an attribute. For this function to work inside a data model, we need to refactor to use the importeddeep_get
frompanther_base_helpers
.Changes
panther_azuresignin_helpers
to importdeep_get
frompanther_base_helpers
panther_azuresignin_helpers.actor_user
to use importeddeep_get
instead ofevent.deep_get
.Testing
Azure.Signin
test rule that usedevent.udm("actor_user")
and confirmed it returned expected result without error