Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor panther_azuresignin_helpers.actor_user to use imported deep_get #1422

Merged

Conversation

ben-githubs
Copy link
Contributor

Background

This function is called from within the Azure.Signin data model code. Data models don't operate on a full Panther Event obejct, but instead get passed an immutable dict, which doesn't have a deep_get function as an attribute. For this function to work inside a data model, we need to refactor to use the imported deep_get from panther_base_helpers.

Changes

  • Update panther_azuresignin_helpers to import deep_get from panther_base_helpers
  • Adjust panther_azuresignin_helpers.actor_user to use imported deep_get instead of event.deep_get.

Testing

  • Wrote an Azure.Signin test rule that used event.udm("actor_user") and confirmed it returned expected result without error
    • test rule is not included in PR

@ben-githubs ben-githubs requested a review from a team as a code owner November 7, 2024 16:34
Copy link

github-actions bot commented Nov 7, 2024

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@arielkr256 arielkr256 added the bug Something isn't working label Nov 12, 2024
@arielkr256 arielkr256 enabled auto-merge (squash) November 12, 2024 16:21
@arielkr256 arielkr256 merged commit ac1ad37 into develop Nov 12, 2024
8 checks passed
@arielkr256 arielkr256 deleted the THREAT-417/make-azure-signin-dm-work-with-immutable-dict branch November 12, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants