Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'applicationName=login for GSuite.ExternalMailForwarding` #1395

Merged
merged 1 commit into from
Oct 22, 2024
+13 −2
Merged

Allow 'applicationName=login for GSuite.ExternalMailForwarding` #1395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rules/gsuite_activityevent_rules/gsuite_external_forwarding.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@


def rule(event):
if event.deep_get("id", "applicationName") != "user_accounts":
if event.deep_get("id", "applicationName") not in ("user_accounts", "login"):
return False

if event.get("name") == "email_forwarding_out_of_domain":
Expand Down
13 changes: 12 additions & 1 deletion rules/gsuite_activityevent_rules/gsuite_external_forwarding.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Runbook: >
SummaryAttributes:
- p_any_emails
Tests:
- Name: Forwarding to External Address
- Name: Forwarding to External Address - applicationName = user_accounts
ExpectedResult: true
Log:
{
Expand All @@ -33,6 +33,17 @@ Tests:
{ "email_forwarding_destination_address": "[email protected]" },
}

- Name: Forwarding to External Address - applicationName = login
ExpectedResult: true
Log:
{
"id": { "applicationName": "login", "customerId": "D12345" },
"actor": { "email": "[email protected]" },
"type": "email_forwarding_change",
"name": "email_forwarding_out_of_domain",
"parameters": { "email_forwarding_destination_address": "[email protected]" }
}

- Name: Forwarding to External Address - Allowed Domain
ExpectedResult: false
Log:
Expand Down
Loading