Helper reorg #1380
Merged
Helper reorg #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
le4ker
reviewed
Oct 9, 2024
le4ker
reviewed
Oct 9, 2024
global_helpers/default_test.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| import unittest | |||
|
|
|||
| sys.path.append(os.path.dirname(__file__)) | |||
| import panther_default as p_d # pylint: disable=C0413 | |||
| import panther_aws_helpers as p_d # pylint: disable=C0413 | |||
There was a problem hiding this comment.
Also the disable=C0413 smells. Probably it's because it has to be bellow the sys.path.append, but we can fix that by moving the sys.path.append in an __init__.py file under the global_helpers directory.
le4ker
reviewed
Oct 9, 2024
| @@ -19,14 +19,16 @@ | |||
|
|
|||
| import panther_asana_helpers as p_a_h # pylint: disable=C0413 | |||
There was a problem hiding this comment.
Interesting, the disable=C0413 is all over the place. I can address it after you merge this PR 😄
le4ker
reviewed
Oct 9, 2024
| @@ -19,14 +19,16 @@ | |||
|
|
|||
| import panther_asana_helpers as p_a_h # pylint: disable=C0413 | |||
| import panther_auth0_helpers as p_auth0_h # pylint: disable=C0413 | |||
| import panther_aws_helpers as p_aws_h # pylint: disable=C0413 | |||
| import panther_azuresignin_helpers as p_asi_h # pylint: disable=C0413 | |||
le4ker
reviewed
Oct 9, 2024
| import panther_cloudflare_helpers as p_cf_h # pylint: disable=C0413 | ||
| import panther_crowdstrike_fdr_helpers as p_cf_fdr_h # pylint: disable=C0413 |
There was a problem hiding this comment.
Maybe p_crowdstrike_fdr_h instead?
le4ker
reviewed
Oct 9, 2024
| import panther_cloudflare_helpers as p_cf_h # pylint: disable=C0413 | ||
| import panther_crowdstrike_fdr_helpers as p_cf_fdr_h # pylint: disable=C0413 | ||
| import panther_greynoise_helpers as p_greynoise_h # pylint: disable=C0413 | ||
| import panther_ipinfo_helpers as p_i_h # pylint: disable=C0413 |
le4ker
reviewed
Oct 9, 2024
| import panther_cloudflare_helpers as p_cf_h # pylint: disable=C0413 | ||
| import panther_crowdstrike_fdr_helpers as p_cf_fdr_h # pylint: disable=C0413 | ||
| import panther_greynoise_helpers as p_greynoise_h # pylint: disable=C0413 | ||
| import panther_ipinfo_helpers as p_i_h # pylint: disable=C0413 | ||
| import panther_lookuptable_helpers as p_l_h # pylint: disable=C0413 |
le4ker
reviewed
Oct 9, 2024
| import panther_greynoise_helpers as p_greynoise_h # pylint: disable=C0413 | ||
| import panther_ipinfo_helpers as p_i_h # pylint: disable=C0413 | ||
| import panther_lookuptable_helpers as p_l_h # pylint: disable=C0413 | ||
| import panther_notion_helpers as p_notion_h # pylint: disable=C0413 | ||
| import panther_oss_helpers as p_o_h # pylint: disable=C0413 | ||
| import panther_snyk_helpers as p_snyk_h # pylint: disable=C0413 | ||
| import panther_tailscale_helpers as p_tscale_h # pylint: disable=C0413 |
le4ker
approved these changes
Oct 9, 2024
le4ker
reviewed
Oct 9, 2024
le4ker
reviewed
Oct 9, 2024
le4ker
reviewed
Oct 9, 2024
arielkr256
added
dependencies
|
😱 |
|
😱 |
le4ker
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
panther_base_helpersis overloaded and contains helpers that are specific to various log sources. This is a large reorg of helper functions to make things more consistent.Changes
panther_base_helpersto their appropriatepanther_<logtype>_helpersmodulepanther_base_helpersis no longer dependent onpanther_configpanther_config_defaultsTesting