fix - IAM User takeover Correlation Rule correlating on IP instead of user #1362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arielkr256
requested changes
Sep 25, 2024
There was a problem hiding this comment.
I think this need to correlate on both IP and target user name. We want to detect when [email protected] resets Bob's password, then Bob logs in from 11.22.33.44.
Username Bob is in the requestParameters.userName field in the PasswordReset rule, and would be the last part of userIdentity.arn in the Login rule.
…ating-on-IP-instead-of-user
@arielkr256 We cannot correlate on both. We can add some context field to both rules that will contain both IP and user name and try correlating on this list, but I'm not sure that this is a good idea (it is not an explicit approach) and that it will work. What do you think about that? |
arielkr256
added
the
correlation_rules
arielkr256
reviewed
Sep 30, 2024
…ating-on-IP-instead-of-user
arielkr256
deleted the
IAM-User-takeover-Correlation-Rule-correlating-on-IP-instead-of-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Fixes #1359
Changes