Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Multi-Table Queries from Packs #1353

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

ben-githubs
Copy link
Contributor

Background

Some of the queries recently added to packs involve more than one table, which may result in the pack failing to update if the customer has not ingested the corresponding log types yet.

Typically, each pack contains items focusing a single log type (or family of log types). When a customer creates a log source for those log types and ingests data, the data lake tables for those log types are also created. In some queries (namely the "Unauthorized Crowdstrike Device" queries), 2 tables are referenced: a crowdstrike table, and whichever log table the pack utilizes. If the customer hasn't previously ingested crowdstrike logs, the crowdstrike table won't exist, and the query will fail to compile (leading to the pack failing to update).

The same issue can happen if we move these queries to the Crowdstrike pack - the other tables may or may not exist. For the time being, we'll remove these queries from any packs until we can determine the best way to package them.

For more context, review this Slack thread.

Changes

Removed any Crowdstrike Unregistered Device queries (and their rules) from any packs. The items still exist in the repo itself.

Testing

  • make test
  • pat check-packs still failed, but not with any new unexpected errors

@ben-githubs ben-githubs requested a review from a team as a code owner September 13, 2024 17:22
Copy link

😱
looks like some things could be wrong with the packs

[INFO][root]: ignoring file dependabot.yml

@ben-githubs
Copy link
Contributor Author

I thought I wanted feedback on: this might disable the detections for any customers who already have the rule through their pack, and added the query manually. I don't expect there to be many (if any) customers who have done this, but worth calling out. The more conservative approach would be to just remove the queries and leave the rules in - the rules will simple never execute if the query isn't present, and if it is, they will operate normally.

Thoughts?

Copy link
Contributor

@arielkr256 arielkr256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arielkr256 arielkr256 merged commit 34512d2 into release Sep 16, 2024
6 checks passed
@arielkr256 arielkr256 deleted the ben/multi-table-queries branch September 16, 2024 15:09
@arielkr256 arielkr256 added bug Something isn't working queries Stored Queries that help to quickly investigate labels Sep 16, 2024
@arielkr256 arielkr256 added the packs New Packs and Expansion of Existing Packs label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working packs New Packs and Expansion of Existing Packs queries Stored Queries that help to quickly investigate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants