Remove Multi-Table Queries from Packs #1353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Some of the queries recently added to packs involve more than one table, which may result in the pack failing to update if the customer has not ingested the corresponding log types yet.
Typically, each pack contains items focusing a single log type (or family of log types). When a customer creates a log source for those log types and ingests data, the data lake tables for those log types are also created. In some queries (namely the "Unauthorized Crowdstrike Device" queries), 2 tables are referenced: a crowdstrike table, and whichever log table the pack utilizes. If the customer hasn't previously ingested crowdstrike logs, the crowdstrike table won't exist, and the query will fail to compile (leading to the pack failing to update).
The same issue can happen if we move these queries to the Crowdstrike pack - the other tables may or may not exist. For the time being, we'll remove these queries from any packs until we can determine the best way to package them.
For more context, review this Slack thread.
Changes
Removed any Crowdstrike Unregistered Device queries (and their rules) from any packs. The items still exist in the repo itself.
Testing
make test
pat check-packs
still failed, but not with any new unexpected errors