Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PCI and DMZ network configuration to panther_config #1018

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

jof
Copy link
Contributor

@jof jof commented Dec 11, 2023

Background

This moves the PCI and DMZ network definitions into the panther_config-based configuration system, which more easily enables downstream organizations to set their own values here.

Surprisingly, in the existing configuration, 100.1.0.0/24 is listed as a DMZ network, but this is a public IP address range belonging to Verizon Business. This seems like a dangerous and incorrect default to have set.
So, I have changed these configuration defaults to be empty -- organization-users will need to set meaningful values for their environment.

Changes

  • Move PCI_NETWORKS and DMZ_NETWORKS to configuration values inside of panther_config. Users should set their own values inside of panther_config_overrides.py

@jof jof force-pushed the jof/public/network-env-config branch from 8a84e9c to 4b9d0b9 Compare December 11, 2023 19:46
@jof jof marked this pull request as ready for review December 11, 2023 19:46
@jof jof requested review from a team December 11, 2023 19:46
@jof jof force-pushed the jof/public/network-env-config branch from 4b9d0b9 to f238ab3 Compare December 11, 2023 23:56
Copy link
Contributor

@egibs egibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice -- good catch with 100.1.0.0/24 as well. I wonder if the intended CIDR block was 10.1.0.0/24 and was entered incorrectly; either way, it's best to let customers define these ranges.

@egibs egibs merged commit 89b6a1f into panther-labs:main Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants