Add PCI and DMZ network configuration to panther_config #1018
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This moves the PCI and DMZ network definitions into the
panther_config
-based configuration system, which more easily enables downstream organizations to set their own values here.Surprisingly, in the existing configuration, 100.1.0.0/24 is listed as a DMZ network, but this is a public IP address range belonging to Verizon Business. This seems like a dangerous and incorrect default to have set.
So, I have changed these configuration defaults to be empty -- organization-users will need to set meaningful values for their environment.
Changes
PCI_NETWORKS
andDMZ_NETWORKS
to configuration values inside ofpanther_config
. Users should set their own values inside ofpanther_config_overrides.py