Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add references to rules (gcp_audit_rules) #1008

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Add references to rules (gcp_audit_rules) #1008

merged 2 commits into from
Dec 12, 2023

Conversation

akozlovets098
Copy link
Contributor

Changes

  • Added references to rules where there weren't ones

@akozlovets098 akozlovets098 requested review from a team December 11, 2023 13:15
le4ker
le4ker reviewed Dec 11, 2023
View reviewed changes
rules/gcp_audit_rules/gcp_destructive_queries.yml Outdated
@@ -3,6 +3,7 @@ Description: Detect any destructive BigQuery queries or jobs such as update, del
DisplayName: "'GCP Destructive Queries '"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the space in the DisplayName

@akozlovets098 akozlovets098 force-pushed the Add-references-to-rules-gcp-audit branch from 2ffcc41 to 7a0d272 Compare December 12, 2023 10:24
@akozlovets098 akozlovets098 merged commit c78cda0 into main Dec 12, 2023
3 checks passed
@akozlovets098 akozlovets098 deleted the Add-references-to-rules-gcp-audit branch December 12, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@le4ker le4ker le4ker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akozlovets098 @le4ker