-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI to Github Actions #471
Conversation
Okay there's ways to install conda with one of their already installed miniconda setups: https://github.com/marketplace/actions/setup-conda |
FYI before we merge this we need to change the "branches" to either "master" or some variable for current branch. I made it |
Fails very uninformative... Error: The operation was canceled. |
Although for py37 esmpy is the problem. https://github.com/pangeo-data/climpred/pull/471/checks?check_run_id=1184207681 |
Making xesmf and esmpy optional should also happen. Just covers the smoothing. Actually .interp_like also does a decent job |
See second tol ast comment JiaweiZhuang/xESMF#47 (comment). I think if you install xesmf before esmpy it should work. |
That ordering works
|
We should switch to pangeo xesmf anyways but they are not on pypi |
Does pip install esmpy not work? Looks like that. Also pip not included here http://www.earthsystemmodeling.org/esmf_releases/non_public/ESMF_7_0_0/esmpy_doc/html/install.html#installing-esmpy |
Yeah we should go ahead and switch over to that |
Maybe calling it minimum.yml |
Picking this up from where you left off. |
Need to switch to CodeCov. See coverallsapp/github-action#30. Coveralls doesn't integrate well here. Testing that now.. |
Looks like actually |
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
===========================================
+ Coverage 0.00% 94.32% +94.32%
===========================================
Files 12 50 +38
Lines 1040 4760 +3720
===========================================
+ Hits 0 4490 +4490
+ Misses 1040 270 -770
Continue to review full report at Codecov.
|
All done in parallel so those all ran fast. Gotta figure out if I need both "push" and "pull request" |
it runs so fast. I dont think pytest is running |
It is running. Click "details" then click the "run tests" dropdown. We don't install all the extra packages and so on with this new environment. |
Do we need to test against py36 37 and 38? Isn’t one enough? |
Yes I think we definitely should. New versions could cause breaking changes we're unaware of. Most other big packages test against these versions. I think it's fine anyways since they're being run in parallel so it isn't a loss of time for us. |
Also, the linter is breaking on |
I think with these multiple env tests we absolutely make the downloads number unreliable. but probably CI is already the majority of downloads. I just dont see which breaking change could come and why we need to test every PR against these. I understand that we should do this once in a while (e.g. before releasing) |
We aren't downloading name: climpred-minimum-tests
channels:
- conda-forge
- defaults
dependencies:
- xesmf
- esmpy
- dask
- netcdf4
- ipython
- nc-time-axis
- coveralls
- pytest
- pytest-cov
- pip
- pip:
- pytest-lazy-fixture
- -e ../.. The last line installs climpred via pip locally. |
42ff849
to
41778fd
Compare
@@ -0,0 +1,22 @@ | |||
name: climpred installs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worth adding this. Found out if you install climpred
from scratch it doesn't work without ipython
and toolz
installs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great improvement. Hard work and very good for our project here.
Description
Updates CI to Github Actions.
Closes #454
To-Do