DEPR: Improve commenting around two deprecations #62398
Open
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
force-pushed
the
update_depr_comments
branch
from
6ffb507 to
350202d
Compare
Comment on lines
+9139
to
+9140
| # TODO: Plan to fix resampling with PeriodIndex instead (#55968) | ||
| # see https://github.com/pandas-dev/pandas/pull/62270#issuecomment-3262411892 |
There was a problem hiding this comment.
Should we also update the warning message with something similar? (that it won't be removed if it can be fixed)
There was a problem hiding this comment.
Seems to me that could encourage users to not use alternatives, which I think is the purpose of keeping the warning with the current behavior.
jbrockmendel
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.I believe these two deprecations are not ready to be enforced, and while we won't enforce in 3.0 we want to keep them as FutureWarnings. With this I plan to move the line items from the 3.0 deprecation issue to the 4.0 issue.
cc @jbrockmendel