-
Notifications
You must be signed in to change notification settings - Fork 501
Fix CI/CD: Labeling and Auto-Documentation #1614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
3be1664 to
b6424ca
Compare
36fa59a to
47e5564
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes CI/CD issues related to automatic documentation publishing and GitHub PR labeling. The changes simplify the documentation workflow, correct path patterns in the labeler configuration, remove an inactive download URL, and improve debug output consistency in the dwarf2 plugin.
- Corrects labeler.yml path patterns by removing unnecessary './' prefixes
- Simplifies the auto-documentation workflow for pypanda docs
- Removes an inactive alternate download URL from qcows.json
- Improves debug output in dwarf2 plugin by converting printf to dprintf and adding conditional debug guards
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/labeler.yml |
Removes './' prefix from all file path patterns to fix labeling logic |
.github/workflows/publish_docker.yml |
Simplifies documentation publishing workflow, pins pdoc3 version, and adds environment variable for protocol buffers |
panda/python/core/pandare/qcows.json |
Removes inactive Dropbox alternate URL for two Ubuntu 18.04 x86_64 QCow entries |
panda/plugins/dwarf2/dwarf2.cpp |
Converts unconditional printf statements to conditional dprintf for debug output, adds debug guards, and improves log messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e83c287 to
907f002
Compare
8a6165f to
635616b
Compare
635616b to
b0dfc69
Compare
b0dfc69 to
26b11df
Compare
d7f5000 to
383f098
Compare
383f098 to
ba59f37
Compare
|
If this works, we should hopefully see a push on master here finally again |
d052368 to
26866a6
Compare
258bba0 to
dbe8fb0
Compare
Your checklist for this pull request
Detailed description
Currently, the CI/CD is being used to update the docs.panda.re isn't working as intended.
...
Test plan
To test locally the same logic, try the following commands:
I updated the commands slightly, and when testing locally, it appears that there is no need to have a separate folder for each branch. See how, based on the screenshot, it seems like the pandare folder is correctly updated.
Finally, with @lacraig2's permission, I'm removing the alternate link to the x86-64 QCow download, as the link is no longer active.
Also, I realized this should have had a few more labels. I found that the issue was that I added './' when it wasn't needed.
...
Closing issues
N/A
...