Skip to content

Conversation

@AndrewQuijano
Copy link
Collaborator

@AndrewQuijano AndrewQuijano commented Nov 24, 2025

Your checklist for this pull request

  • I've documented or updated the documentation of every API function and struct this PR changes.
  • I've added tests that prove my fix is effective or that my feature works (if possible)

Detailed description

Currently, the CI/CD is being used to update the docs.panda.re isn't working as intended.
...

Test plan

To test locally the same logic, try the following commands:

# Just to test locally, let's just have $HOME be our GITHUB_WORKSPACE.
GITHUB_WORKSPACE=$(echo $HOME)

# Replicate creating documents
git clone git@github.com:panda-re/panda-re.github.io.git --branch=master ${GITHUB_WORKSPACE}/auto_pydoc/pandare

# Create docs
docker run --rm -e PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=python -v ${GITHUB_WORKSPACE}/auto_pydoc:/out pandare/pandadev:latest /bin/sh -c "pip3 install pdoc3==0.10.0; cd /panda/panda/python/core; pdoc3 --html --template-dir=../docs/template --force -o /out/ pandare;"

I updated the commands slightly, and when testing locally, it appears that there is no need to have a separate folder for each branch. See how, based on the screenshot, it seems like the pandare folder is correctly updated.

Finally, with @lacraig2's permission, I'm removing the alternate link to the x86-64 QCow download, as the link is no longer active.

Also, I realized this should have had a few more labels. I found that the issue was that I added './' when it wasn't needed.

image

...

Closing issues

N/A
...

@AndrewQuijano AndrewQuijano force-pushed the documentation branch 2 times, most recently from 3be1664 to b6424ca Compare November 24, 2025 23:04
@AndrewQuijano AndrewQuijano marked this pull request as ready for review November 24, 2025 23:06
@AndrewQuijano AndrewQuijano linked an issue Nov 25, 2025 that may be closed by this pull request
@AndrewQuijano AndrewQuijano force-pushed the documentation branch 3 times, most recently from 36fa59a to 47e5564 Compare November 28, 2025 01:07
@AndrewQuijano AndrewQuijano changed the title Fix auto documentation CI/CD Fix CI/CD: Labeling and Auto-Documentation Nov 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CI/CD issues related to automatic documentation publishing and GitHub PR labeling. The changes simplify the documentation workflow, correct path patterns in the labeler configuration, remove an inactive download URL, and improve debug output consistency in the dwarf2 plugin.

  • Corrects labeler.yml path patterns by removing unnecessary './' prefixes
  • Simplifies the auto-documentation workflow for pypanda docs
  • Removes an inactive alternate download URL from qcows.json
  • Improves debug output in dwarf2 plugin by converting printf to dprintf and adding conditional debug guards

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
.github/labeler.yml Removes './' prefix from all file path patterns to fix labeling logic
.github/workflows/publish_docker.yml Simplifies documentation publishing workflow, pins pdoc3 version, and adds environment variable for protocol buffers
panda/python/core/pandare/qcows.json Removes inactive Dropbox alternate URL for two Ubuntu 18.04 x86_64 QCow entries
panda/plugins/dwarf2/dwarf2.cpp Converts unconditional printf statements to conditional dprintf for debug output, adds debug guards, and improves log messages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AndrewQuijano AndrewQuijano force-pushed the documentation branch 2 times, most recently from 8a6165f to 635616b Compare January 14, 2026 01:52
@AndrewQuijano AndrewQuijano force-pushed the documentation branch 2 times, most recently from d7f5000 to 383f098 Compare January 15, 2026 18:54
@AndrewQuijano
Copy link
Collaborator Author

If this works, we should hopefully see a push on master here finally again

https://github.com/panda-re/panda-re.github.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x86_64 dropbox link was deleted

3 participants