Tech Debt/Prep: LAVA Multiple Files and Inject Fixes #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
AndrewQuijano
force-pushed
the
bugs
branch
2 times, most recently
from
e2b1111 to
721bcf3
Compare
AndrewQuijano
force-pushed
the
bugs
branch
10 times, most recently
from
113ad3b to
a595234
Compare
AndrewQuijano
force-pushed
the
bugs
branch
5 times, most recently
from
bf75cfd to
8daa1df
Compare
AndrewQuijano
changed the title
AndrewQuijano
force-pushed
the
bugs
branch
2 times, most recently
from
3acf27c to
1f7be4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
This PR has the following tasks completed:
Upgrade LAVA so it can pass a folder of inputs to run inside PANDA. This would ensure that if new inputs are generated, no structural changes are needed to LAVA. This should only be merged once this PANDA PR is merged. (CURRENTLY IT IS COMMENTED, BUT THIS HAS BEEN TESTED AND WORKS).
For btrace now uses cJSON to create the JSON for compiling commands.
bug_mining.py, we cleaned this to be written into functions with docstrings.
inject.py has had some work on cleaning up dead inputs, consolidation, etc.
I did make the choice to delete checking input DUA files. I'll see if I regret it, but for now it still works. Furthermore, we can always restore this logic.
I should note, now that file_taint can log when a specific file is tainted, we probably should bring this logic back. For now, next priority is fully replace bash with full Python.
Things to note:
For some reason, there are more bugs detected on this iteration than past ones. I have no idea why, but the test still passes, so... I'll ignore this for now.
...
Test plan
Confirm that CI/CD passes for toy. Also, verify that file_taint via logs is correctly tainting multiple files.
...
Closing issues
...