Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion]: store poolid in array #93

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ChefMist
Copy link
Collaborator

@ChefMist ChefMist commented Jun 27, 2024

This PR show the gas usage if we also have a mapping which store poolIds[uint256 poollength] = bytes32 poolId

Context
to add context if we want to include this PR

206492
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

44k more gas

@ChefMist ChefMist changed the title poc: store poolid in array [Discussion]: store poolid in array Jun 27, 2024
Base automatically changed from feat/add-poolId-to-poolKey-map to main June 28, 2024 03:51
@ChefMist
Copy link
Collaborator Author

per initial discussion, likely not required. will leave it for a bit longer to see if there's feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant