You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR focuses on optimizing the fetching of currency prices and pool data by eliminating duplicate requests and improving performance through the use of lodash's uniqBy function.
Detailed summary
Added uniqBy from lodash to filter unique currency parameters in usdPriceBatcher.
Renamed totalSupplyCalls to endTimestampCalls.
Updated calls to use activeValidPools instead of validPools.
Removed redundant endTimestampCalls and adjusted related logic.
Simplified Promise.all calls for fetching data.
✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
The reason will be displayed to describe this comment to others. Learn more.
batcher shallowly compares currencyparams (which are tokens where it is called) and if same tokens are different objects it can be double fetched because of that
memoyil
changed the title
perf: Dont fetch v2 expired pools data
perf: Dont fetch v2 expired pools data and make price fetcher unique
Oct 24, 2024
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
memoyil
requested review from
ChefMomota,
Chef-Yogi,
chefjackson,
ChefJerry,
thechefpenguin,
chef-eric and
chef-ryan
as code owners
PR-Codex overview
This PR focuses on optimizing the fetching of currency prices and pool data by eliminating duplicate requests and improving performance through the use of
lodash'suniqByfunction.Detailed summary
uniqByfromlodashto filter unique currency parameters inusdPriceBatcher.totalSupplyCallstoendTimestampCalls.activeValidPoolsinstead ofvalidPools.endTimestampCallsand adjusted related logic.