-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added linebreak option for indent filter. #2031
base: main
Are you sure you want to change the base?
Conversation
The issue points out that the environment already has a setting for the line ending. That should be used instead of adding a filter argument. |
As stated in #2016 , the changes addressed my use case. Was any search for any other instances of hardcoded use of '\n' made? |
I don't think so. If you (or someone else) want to look, and find other places that should use the env setting, that would be another good issue to open. |
There is nothing else in filters.py, the only thing in /src I'm questioning is: Line 457 in ada0a9a
But as in the compiler.py, thinking it is not an issue. |
You're right, that's not an issue. |
This change fixes the indent filter so that it can support any line break sequence, including line feed (LF), carriage return line feed (CRLF), and carriage return (CR), whichever newline sequence is set in the environment.
#2016
fixes #2016
👋 This is my first time contributing, please advise if an entry to CHANGES.rst should be added and which version it should be associated (e.g. 3.2.0).