Skip to content

fix: _termui_impl.open_url() — 'start' on Windows is a cmd built-in, not an executable #3186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
karpierz wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

fix: _termui_impl.open_url() — 'start' on Windows is a cmd built-in, not an executable #3186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/click/_termui_impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -697,6 +697,7 @@ def _unquote_file(url: str) -> str:
finally:
null.close()
elif WIN:
shell = False
if locate:
url = _unquote_file(url)
args = ["explorer", f"/select,{url}"]
Expand All @@ -706,8 +707,9 @@ def _unquote_file(url: str) -> str:
args.append("/WAIT")
args.append("")
args.append(url)
shell = True
try:
return subprocess.call(args)
return subprocess.call(args, shell=shell)
except OSError:
# Command not found
return 127
Expand Down
Loading