Use subprocess instead of os.system #1477
Conversation
davidism
changed the title
|
Master is now Python 3 only. This needs to be rebased, and compat for #1543 reverts the previous >>> shlex.split("C:\\path\\to\\exe /test other\\path")
['C:pathtoexe', '/test', 'otherpath']
>>> shlex.split("C:\\path\\to\\exe /test other\\path".replace("\\", "\\\\"))
['C:path\\to\\exe', '/test', 'other\\path']
>>> shlex.split("C:\\path\\to\\exe /test other\\path", posix=False)
['C:path\\to\\exe', '/test', 'other\\path']Technically that last one with |
| @@ -377,16 +378,16 @@ def pager(generator: t.Iterable[str], color: t.Optional[bool] = None) -> None: | |||
| if os.environ.get("TERM") in ("dumb", "emacs"): | |||
| return _nullpager(stdout, generator, color) | |||
| if WIN or sys.platform.startswith("os2"): | |||
| return _tempfilepager(generator, "more <", color) | |||
| if hasattr(os, "system") and os.system("(less) 2>/dev/null") == 0: | |||
| return _tempfilepager(generator, "more", color, pipe=True) | |||
There was a problem hiding this comment.
I noticed _pipepager exists now. Should we not use that instead here and remove the pipe argument I introduced?
closes #1026, closes #1470, closes #1476