Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #1312: Type (typehint) error when calling db.Model subclass constructor with parameters #1321

Open
wants to merge 10 commits into
base: stable
Choose a base branch
from
Open

Fix issue #1312: Type (typehint) error when calling db.Model subclass constructor with parameters #1321

wants to merge 10 commits into from

Commits on Mar 27, 2024

  1. Solve the issue pallets-eco#1312 

    1. Provide a descriptor `ModelGetter` for solving the `db.Model` type from the `db` type dynamically.
2. Add `t.Type[sa_orm.MappedAsDataclass]` to `_FSA_MCT`.
3. Let `SQLAlchemy(...)` annotated by the provided `model_class` type.
    @cainmagi
    cainmagi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    dcc2a23 View commit details
    Browse the repository at this point in the history

  2. Ensure the full type hints for parameterized SQLAlchemy.

    @cainmagi
    cainmagi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    8f2bfd1 View commit details
    Browse the repository at this point in the history

  3. Ensure the full type hints for parameterized SQLAlchemy in all test… 

    … codes.
    @cainmagi
    cainmagi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    1638622 View commit details
    Browse the repository at this point in the history

  4. Fix an issue when tox p fails because mypy is forbidden. 

    See details here: https://stackoverflow.com/a/47716994/8266012
    @cainmagi
    cainmagi committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    3065b7c View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Merge branch '3.1.x' into fix-issue-1312

    @cainmagi
    cainmagi authored Apr 29, 2024
    Configuration menu
    Copy the full SHA
    0c9f711 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    2dddeb7 View commit details
    Browse the repository at this point in the history

  3. t.Type -> type to match the pre-commit check.

    @cainmagi
    cainmagi committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    3c46668 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    d408894 View commit details
    Browse the repository at this point in the history

  5. Change t.Union/t.Optional to "|" operator to prevent tox -p to fail.

    @cainmagi
    cainmagi committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    9b97634 View commit details
    Browse the repository at this point in the history

  6. t.cast should accept t.Type[...] instead of type[...] to preven… 

    …t runtime failure in python3.8.
    @cainmagi
    cainmagi committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    f383186 View commit details
    Browse the repository at this point in the history