Update flaskr and todo to use SQLAlchemy 2.0 style #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamelafox
commented
Sep 3, 2023
| from werkzeug.security import check_password_hash | ||
| from werkzeug.security import generate_password_hash | ||
|
|
||
| from flaskr import db | ||
|
|
||
| if TYPE_CHECKING: | ||
| from flaskr.blog.models import Post |
There was a problem hiding this comment.
Needed due to circular import
ThiefMaster
reviewed
Sep 3, 2023
ThiefMaster
reviewed
Sep 3, 2023
pamelafox
changed the title
davidism
force-pushed
the
update-flaskr
branch
from
7f79482
to
144495a
Compare
davidism
approved these changes
Sep 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Flaskr and todo sample apps to use 2.0 style models. All flaskr tests pass.
Checklist:
- [ ] Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.- [ ] Add or update relevant docs, in the docs folder and in code.- [ ] Add an entry inCHANGES.rstsummarizing the change and linking to the issue.- [ ] Add.. versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.