Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit top-level sg from VPC launch-options #11

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mccraigmccraig
Copy link

If an instance is placed in a VPC by providing :network-interfaces
options then the top-level security group name munged from the
pallet group name must not be used, or the AWS API will throw an
Exception.

This commit omits the :security-groups key from launch-options
when the node-spec has a [:provider :pallet-ec2 :network-interfaces]
key.

The problem is described in more detail with stacktraces here :

https://groups.google.com/forum/#!topic/pallet-clj/sWu-4IanCW0

If an instance is placed in a VPC by providing :network-interfaces
options then the top-level security group name munged from the
pallet group name must not be used, or the AWS API will throw an
Exception.

This commit omits the :security-groups key from launch-options
when the node-spec has a [:provider :pallet-ec2 :network-interfaces]
key.
@mccraigmccraig
Copy link
Author

hmm. this may be ill-conceived... the sg-id should ideally be gotten from the group-spec rather than the node-spec... i will consider further tomorrow

@mccraigmccraig
Copy link
Author

ok,

so, despite specifying the security-group-id on the node-spec possibly requiring that a different version of the node-spec (with a different security-group-id) will be required for each group, this seems to be the way it is currently done

in which context, this PR seems reasonable

@mccraigmccraig
Copy link
Author

on further investigation, it seems that pallet-aws uses a tag on instances to keep track of the pallet group that an instance belongs to, so there's no need to specialise node-specs with different security groups, so this PR seems even more reasonable (apologies for my thrashing about : i'm a pallet n00b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant