fix(vault): fix default network id setting

[mrcnk]

Describe changes

Ticket or discussion link

Review checklist

• Proper documentation added
• Proper tests added

Screenshots

[deepsource-io]

Here's the code health analysis summary for commits 2f43e8d..7343baa. View details on DeepSource ↗.

Analysis Summary

Analyzer	Status	Summary	Link
JavaScript	✅ Success	❗ 1 occurence introduced 🎯 1 occurence resolved	View Check ↗

---

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

To fix the prototype pollution issue, we need to ensure that the networkId parameter cannot be set to special property names like __proto__, constructor, or prototype. We can achieve this by adding a check to reject these values before using them as keys in the state.accounts object.

The best way to fix this without changing existing functionality is to add a validation step for networkId in each function where it is used. If networkId is one of the special property names, we can return early or throw an error.

To fix the prototype pollution vulnerability, we need to ensure that networkId cannot be set to special property names like __proto__, constructor, or prototype. One way to achieve this is by adding a check to reject these values before using them as keys. Alternatively, we can use a Map object instead of a plain object to store the accounts, as Map does not have the same prototype pollution risks.

The best way to fix the problem without changing existing functionality is to add a check to reject special property names. This approach is straightforward and does not require significant changes to the existing code structure.

To fix the problem, we need to ensure that networkId cannot be used to manipulate the prototype of the object. One effective way to achieve this is by validating networkId to ensure it does not contain any dangerous values like __proto__, constructor, or prototype. Alternatively, we can use a Map object instead of a plain object to store the accounts, as Map is not vulnerable to prototype pollution.

The best way to fix the problem without changing existing functionality is to validate networkId before using it as a key. We will add a check to ensure networkId is not one of the dangerous values.

To fix the prototype pollution vulnerability, we need to ensure that the networkId parameter cannot be used to modify Object.prototype. This can be achieved by validating the networkId and rejecting any values that could lead to prototype pollution, such as __proto__, constructor, or prototype.

The best way to fix this without changing existing functionality is to add a validation check for networkId before it is used as a key in the state.accounts object. If networkId is one of the restricted values, we should return early or handle it appropriately.