Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internationalization and replace all hardcoded labels with i18n entries #215

Merged
merged 7 commits into from
Nov 7, 2024

Conversation

ManyRios
Copy link
Contributor

@ManyRios ManyRios commented Oct 17, 2024

Describe changes

Added react-i18next dependency for packages/features.
Added all necessary config files for the i18next library.
Extracted all necessary i18n entries from hardcoded labels in Pallad to locales/en.json

Ticket or discussion link

#194

All the labels has been changed in packages/features.

@mrcnk

Copy link

deepsource-io bot commented Oct 17, 2024

Here's the code health analysis summary for commits 8be9df3..617834a. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ Success
❗ 12 occurences introduced
🎯 13 occurences resolved
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@ManyRios
Copy link
Contributor Author

@mrcnk Please review

@ManyRios
Copy link
Contributor Author

Hey @mrcnk

@ManyRios
Copy link
Contributor Author

ManyRios commented Nov 5, 2024

@mrcnk please review this PR

@mrcnk mrcnk merged commit 86c9df9 into palladians:main Nov 7, 2024
2 checks passed
@mrcnk
Copy link
Member

mrcnk commented Nov 7, 2024

@all-contributors please add @ManyRios for code

Copy link
Contributor

@mrcnk

I've put up a pull request to add @ManyRios! 🎉

@ManyRios ManyRios deleted the i18next branch November 7, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants