Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Word Number Labels to Mnemonic Inputs in Wallet Restoration Flow #202

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

aliraza556
Copy link
Contributor

@aliraza556 aliraza556 commented Aug 21, 2024

Problem:

  • The word number label disappears when the user types in the mnemonic input field.

closes: #190

Issue ticket number and link:

Evidence:

https://www.loom.com/share/7cc9a86b55ce4457ba6b943530f5b633

image

Acceptance Criteria

  • Each Seed Import input should have a label inside the input with an according word number.
  • It should work fine on smaller side panels - inputs should be responsive.

Copy link

deepsource-io bot commented Aug 21, 2024

Here's the code health analysis summary for commits 678ec59..b789a36. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@aliraza556
Copy link
Contributor Author

Hi @mrcnk Please review this PR.

@mrcnk
Copy link
Member

mrcnk commented Aug 21, 2024

Hi @aliraza556, it's almost perfect, can you just make sure the label has enough of spacing for double digit numbers? It's a little too close.
CleanShot 2024-08-21 at 11 10 04@2x
When it's fixed I'm gonna merge and let you know how we do bounty pay outs with https://astromina.org/.

@aliraza556
Copy link
Contributor Author

When it's fixed I'm gonna merge and let you know how we do bounty pay outs with https://astromina.org/.

@mrcnk Ok I fix it and then ping you.

@aliraza556
Copy link
Contributor Author

Hi @mrcnk, Please merge this PR.

image

@aliraza556
Copy link
Contributor Author

Hi @aliraza556, it's almost perfect, can you just make sure the label has enough of spacing for double digit numbers? It's a little too close. CleanShot 2024-08-21 at 11 10 04@2x When it's fixed I'm gonna merge and let you know how we do bounty pay outs with https://astromina.org/.

@mrcnk Fixed

@mrcnk
Copy link
Member

mrcnk commented Aug 21, 2024

@aliraza556 now it's the other way around, the single digit number labels are too close 😅

CleanShot 2024-08-21 at 14 08 00

@aliraza556
Copy link
Contributor Author

@aliraza556 now it's the other way around, the single digit number labels are too close 😅

CleanShot 2024-08-21 at 14 08 00

ok I try to fix it

@aliraza556
Copy link
Contributor Author

aliraza556 commented Aug 21, 2024

@mrcnk Done:

image

@mrcnk
Copy link
Member

mrcnk commented Aug 21, 2024

@aliraza556 please format the code with "pnpm format:unsafe" and push again, that should make it complete and bounty will be on the way to you

@aliraza556
Copy link
Contributor Author

@mrcnk Please approve the workflows

@mrcnk mrcnk merged commit a674fbc into palladians:main Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add word number label to mnemonic inputs in wallet restoration flow
2 participants