Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a password strength label #200

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Add a password strength label #200

merged 1 commit into from
Aug 21, 2024

Conversation

yaodingyd
Copy link
Contributor

Describe changes

fix #193

Changes:

  • Added new dep zxcvbn-ts/core
  • Implemented a password strength label based on user input.
  • Since zxcvbn returns 5 levels which is more granular, I added a intermediate level of text

Ticket or discussion link

Review checklist

  • Proper documentation added
  • Proper tests added

Screenshots

2024-08-20_22-04-59.mp4

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Aug 21, 2024

Here's the code health analysis summary for commits 997f6c6..9c44562. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@mrcnk mrcnk merged commit d8f1344 into palladians:main Aug 21, 2024
2 checks passed
@yaodingyd yaodingyd deleted the password-label branch August 21, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrcnk mrcnk mrcnk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a simple password strength label
2 participants
@yaodingyd @mrcnk