[Gradle JDK Automanagement][Intellij plugin] Background tool window #405
Conversation
| @@ -90,7 +110,28 @@ public void maybeSetupGradleJdks() { | |||
| "Skipping setupGradleJdks because gradle JDK setup is not found %s", gradleSetupScript)); | |||
| return; | |||
| } | |||
| setupGradleJdks(); | |||
| TasksKt.withBackgroundProgress( | |||
There was a problem hiding this comment.
instead of: https://github.com/JetBrains/intellij-community/blob/99964dd3c76f6cf9eb24018c002a68848e54dddb/platform/core-api/src/com/intellij/openapi/progress/Task.java#L43C8-L43C12 which has obsolescence notice
| TasksKt.withBackgroundProgress( | ||
| project, | ||
| "Gradle JDK Setup", | ||
| (_coroutineScope, continuation) -> { | ||
| StepsKt.withProgressText( | ||
| "`Gradle JDK Setup` is running. Logs in the `Gradle JDK Setup` window ...", | ||
| (_cor, conti) -> { | ||
| setupGradleJdks(); | ||
| return conti; | ||
| }, | ||
| continuation); | ||
| return continuation; | ||
| }, | ||
| new Continuation<>() { | ||
| @Override | ||
| public @NotNull CoroutineContext getContext() { | ||
| return EmptyCoroutineContext.INSTANCE; | ||
| } | ||
|
|
||
| @Override | ||
| public void resumeWith(@NotNull Object _object) {} | ||
| }); |
There was a problem hiding this comment.
the Gradle JDK setup process would look similar to the Gradle Sync background process. The logs can be seen in Gradle JDK Setup window tab.
| @@ -109,6 +151,21 @@ public void processTerminated(@NotNull ProcessEvent _event) { | |||
| consoleView.get().attachToProcess(handler); | |||
| ProcessTerminatedListener.attach(handler, project, "Gradle JDK setup finished with exit code $EXIT_CODE$"); | |||
| handler.waitFor(); | |||
| if (handler.getExitCode() != 0) { | |||
| Notification notification = NotificationGroupManager.getInstance() | |||
There was a problem hiding this comment.
if the process has failed for any reason, a pop-up will appear:
I could also focus the Gradle JDK setup window tool by default. wdyt ?
There was a problem hiding this comment.
I think it makes sense to focus the window on failure. The notification windows are quite quiet. I for some reason barely ever notice the "required plugins" notification lolol and I think it's quite common.
There was a problem hiding this comment.
addressed in: aceac47
| @@ -72,13 +83,22 @@ private ConsoleView initConsoleView() { | |||
| ContentFactory contentFactory = ContentFactory.getInstance(); | |||
| Content content = contentFactory.createContent(newConsoleView.getComponent(), "", false); | |||
| toolWindow.getContentManager().addContent(content); | |||
| // TODO(crogoz): Focus only when error or takes a long time? | |||
| toolWindow.activate(null); | |||
| Disposer.register(project, newConsoleView); | |||
There was a problem hiding this comment.
maybe this fixes: #394 I wasn't able to repro the issue
|
Released 0.47.0 |
Before this PR
After this PR
Fixes: #395
Gradle JDK setuptool window will be minimized by defaultGradle JDK setupwould look as if it were a background process (similar to theGradle Syncworkflow)Gradle JDK setupfails, then we will show a pop-up Notification with a link to the logs.==COMMIT_MSG==
[Gradle JDK Automanagement][Intellij plugin] Background tool window
==COMMIT_MSG==
Note: I've tried using the declarative setup for the
Gradle JDK setuptoolWindow (https://plugins.jetbrains.com/docs/intellij/tool-windows.html#declarative-setup) but the workflow had 2 issues:Possible downsides?