Skip to content

use GradleExec#exec over ProviderFactory#exec #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

use GradleExec#exec over ProviderFactory#exec #210

wants to merge 7 commits into from

Conversation

FinlayRJW
Copy link
Contributor

Before this PR

Had no errorprone to encourage the usage of GradleExec

After this PR

We now have an errorprone to force the usage of GradleExec#exec with updated README

See palantir/gradle-utils#435 (comment) for reference

==COMMIT_MSG==
use GradleExec#exec over ProviderFactory#exec
==COMMIT_MSG==

Possible downsides?

Finlay Williams added 2 commits September 1, 2025 15:42
@changelog-app
Copy link

changelog-app bot commented Sep 1, 2025 •
edited by FinlayRJW
Loading

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

use GradleExec#exec over ProviderFactory#exec

Check the box to generate changelog(s)

  • Generate changelog entry

@changelog-app
Copy link

changelog-app bot commented Sep 1, 2025

✅ Successfully generated changelog entry!

What happened?

Your changelog entries have been stored in the database as part of our migration to ChangelogV3.

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.

@FinlayRJW FinlayRJW mentioned this pull request Sep 1, 2025
Open
kelvinou01
kelvinou01 reviewed Sep 1, 2025
View reviewed changes
Copy link
Contributor

@kelvinou01 kelvinou01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉
I think this is good to go. Let's wait for a review from @CRogers before we merge.

guide/adopting-the-configuration-cache.md
@Inject
protected abstract ProviderFactory getProviderFactory();
@Nested
protected abstract GradleExec getGradleExec();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's test that this compiles!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should do thats how its used currently - https://github.com/palantir/gradle-utils/blob/develop/platform/src/main/java/com/palantir/platform/GradleOperatingSystem.java#L33

@FinlayRJW
Copy link
Contributor Author

marked as DNM until we settle how we want to handle errors (i.e palantir/gradle-utils#435) so we don't roll this out only to have to update later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelvinou01 kelvinou01 kelvinou01 left review comments

Assignees
No one assigned
Labels
autorelease do not merge merge when ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FinlayRJW @kelvinou01