Introduce getProductDependenciesTransformers to ConjureProductDependenciesExtension to help unblock configuration cache
#1657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 3, 2025 10:51
Generate changelog in
|
CRogers
reviewed
Jul 3, 2025
...e-api/src/main/java/com/palantir/gradle/conjure/api/ConjureProductDependenciesExtension.java
Outdated
Show resolved
Hide resolved
added 4 commits
July 4, 2025 11:45
FinlayRJW
changed the title
getProductDependenciesTransformers to ConjureProductDependenciesExtension to help unblock configuration cache
FinlayRJW
commented
Jul 4, 2025
| - code: "java.annotation.removed" | ||
| old: "method void com.palantir.gradle.conjure.api.ConjureProductDependenciesExtension::<init>(org.gradle.api.Project)" | ||
| new: "method void com.palantir.gradle.conjure.api.ConjureProductDependenciesExtension::<init>()" | ||
| justification: "ConjureProductDependenciesExtension has been modernised to use\ |
There was a problem hiding this comment.
Is this a good enough justification? should I do a separate one for each break?
FinlayRJW
commented
Jul 4, 2025
...njure/src/test/java/com/palantir/gradle/conjure/ConjureProductDependenciesExtensionTest.java
Outdated
Show resolved
Hide resolved
added 3 commits
July 7, 2025 15:15
…ir/gradle-conjure into finlayw/fix-minimum-version-issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Previously there was no mechanism for other plugins to safely modify the
ConjureProductDependenciesExtension.getProductDependenciesthis resulted in other plugins just modifying the state ofgetProductDependencieson the extension directly. This used to work from dumb luck but now we are rolling configuration cache out theconvertDependenciesmethod is called before other plugins have a change to modify the stateAfter this PR
Fundamentally this is meant to be a light touch PR we want to unblock configuration cache without having to do a massive re-write of
gradle-conjureat some point we will be force to comeback and make a lot of changes but for now I'm trying to keep it minimalIf we where to build this from the ground up we should have used the
NamedDomainContainerbut this forces you to change the was you setserviceDependenciesin yourbuild.gradleso instead we settled on adding agetProductDependenciesTransformersmethod on the extension that allows other plugins to add methods that modify theServiceDependencyas late as possible==COMMIT_MSG==
==COMMIT_MSG==
Possible downsides?
I couldn't figure out how to get a test working in the
IntegrationSpecso I've added a small java test for the extension this can be a FLUP if it is criticalThis does introduce a few breaks!
getProductDependenciesandgetEndpointVersionsare nowSetPropertiesConjureProductDependenciesExtensionis abstractThis should not be much of a problem we only seriously use this extension in one internal plugin -> https://pl.ntr/2v9 a PR to fix this there will follow soon