Change ImmutablesStyle's retention policy (#369)

Change immutablesStyle's retention policy to be SOURCE instead of CLASS, and make SerializableError use it. This avoids compilation warnings for consumers that don't depend on immutables.
palantir · Oct 24, 2019 · d77cfee · d77cfee
1 parent 1c9d854
commit d77cfee
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/errors/src/main/java/com/palantir/conjure/java/api/errors/ImmutablesStyle.java b/errors/src/main/java/com/palantir/conjure/java/api/errors/ImmutablesStyle.java
@@ -23,7 +23,7 @@
 import org.immutables.value.Value;
 
 @Target({ElementType.PACKAGE, ElementType.TYPE})
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.SOURCE)
 @Value.Style(
         visibility = Value.Style.ImplementationVisibility.PACKAGE,
         overshadowImplementation = true,

diff --git a/errors/src/main/java/com/palantir/conjure/java/api/errors/SerializableError.java b/errors/src/main/java/com/palantir/conjure/java/api/errors/SerializableError.java
@@ -36,7 +36,8 @@
 @JsonDeserialize(builder = SerializableError.Builder.class)
 @JsonSerialize(as = ImmutableSerializableError.class)
 @Value.Immutable
-@Value.Style(visibility = Value.Style.ImplementationVisibility.PACKAGE, jdkOnly = true)
+@ImmutablesStyle
+@Value.Style(overshadowImplementation = false)
 @JsonIgnoreProperties(ignoreUnknown = true)
 public abstract class SerializableError implements Serializable {
 

diff --git a/...ce-config/src/main/java/com/palantir/conjure/java/api/config/service/ImmutablesStyle.java b/...ce-config/src/main/java/com/palantir/conjure/java/api/config/service/ImmutablesStyle.java
@@ -23,7 +23,7 @@
 import org.immutables.value.Value;
 
 @Target({ElementType.PACKAGE, ElementType.TYPE})
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.SOURCE)
 @Value.Style(
         visibility = Value.Style.ImplementationVisibility.PACKAGE,
         overshadowImplementation = true,

diff --git a/ssl-config/src/main/java/com/palantir/conjure/java/api/config/ssl/ImmutablesStyle.java b/ssl-config/src/main/java/com/palantir/conjure/java/api/config/ssl/ImmutablesStyle.java
@@ -23,7 +23,7 @@
 import org.immutables.value.Value;
 
 @Target({ElementType.PACKAGE, ElementType.TYPE})
-@Retention(RetentionPolicy.CLASS)
+@Retention(RetentionPolicy.SOURCE)
 @Value.Style(
         visibility = Value.Style.ImplementationVisibility.PACKAGE,
         overshadowImplementation = true,