Skip to content

improvement: Validate bearer tokens #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

improvement: Validate bearer tokens #229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9bbd31
improvement: Validate bearer tokens
bmoylan Oct 18, 2021
3bfc9a2
Add generated changelog entries
svc-changelog Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/@unreleased/pr-229.v2.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
type: improvement
improvement:
description: Validate bearer tokens
links:
- https://github.com/palantir/conjure-go/pull/229
11 changes: 0 additions & 11 deletions conjure-go-verifier/ignored-test-cases.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,9 @@ client:
- '[null]'
receiveSetAnyAliasExample:
- '[null]'
receiveBearerTokenAliasExample:
- '""'
receiveBearerTokenExample:
- '{"value":null}'
- '{}'
- '{"value":" space"}'
- '{"value":"space "}'
- '{"value":"with space"}'
- '{"value":""}'
- '{"value":"#"}'
- '{"value":" "}'
- '{"value":"("}'
- '{"value":"="}'
- '{"value":"=a"}'
receiveBinaryExample:
- '{"value":null}'
- '{}'
Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ require (
github.com/palantir/goastwriter v0.1.0
github.com/palantir/godel-conjure-plugin/v5 v5.1.0
github.com/palantir/godel/pkg/products/v2 v2.0.0
github.com/palantir/pkg/bearertoken v1.0.1
github.com/palantir/pkg/bearertoken v1.0.2-0.20211018212129-dd668d3dcdb4
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires palantir/pkg#222

github.com/palantir/pkg/binary v1.0.1
github.com/palantir/pkg/boolean v1.0.0
github.com/palantir/pkg/cobracli v1.0.1
Expand Down
3 changes: 2 additions & 1 deletion go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,8 +323,9 @@ github.com/palantir/pkg v0.0.0-20181230161202-d12f4064ff8e/go.mod h1:jLbXCfQ4HRr
github.com/palantir/pkg v1.0.1 h1:ZbGUcc14N7xcZSY9cehQoiHHTm/BAZO5RJdlsNEtSbk=
github.com/palantir/pkg v1.0.1/go.mod h1:Eo6Jl0UXfT+65sLXJOcU9duu0WPvKsWFXCb0dE5VWZs=
github.com/palantir/pkg/bearertoken v1.0.0/go.mod h1:avqDPtNT8TtRgLsOctPfGXwD62AWBMbhNn4iIv0GKo4=
github.com/palantir/pkg/bearertoken v1.0.1 h1:GoWT/ihU6YHZFonvFRWiAcWQxpdNF+K3rBKSifBnbBU=
github.com/palantir/pkg/bearertoken v1.0.1/go.mod h1:2Cv+3lHNBZLge2i0HehP1K5GCnkhE6YZrJLVXJcskG0=
github.com/palantir/pkg/bearertoken v1.0.2-0.20211018212129-dd668d3dcdb4 h1:UaeE+mRjJJPtlnZzkHjdSQaRdcRQzqhj1GQRAmssYNM=
github.com/palantir/pkg/bearertoken v1.0.2-0.20211018212129-dd668d3dcdb4/go.mod h1:woFbOZmrW77hgWgiYKH7wRBfUGUvcTJ8kKNt5fAz8MY=
github.com/palantir/pkg/binary v1.0.0/go.mod h1:fARS9aw2WQBGHh1I68LnVEi6nnGXe1UwWQTOr2K8Ack=
github.com/palantir/pkg/binary v1.0.1 h1:sMAcooNCkC0VU7W3wTQECigHM3pxmXwHZN53/pM8bpo=
github.com/palantir/pkg/binary v1.0.1/go.mod h1:fCwVNRbc0rEuqDcmGSwdgx4cqBq7/5zUD1BS8DsCm64=
Expand Down
51 changes: 50 additions & 1 deletion vendor/github.com/palantir/pkg/bearertoken/bearertoken.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions vendor/github.com/palantir/pkg/bearertoken/go.mod
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions vendor/github.com/palantir/pkg/bearertoken/go.sum
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

76 changes: 54 additions & 22 deletions vendor/github.com/palantir/pkg/bearertoken/godelw
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vendor/modules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ github.com/palantir/godel-conjure-plugin/v5/ir-gen-cli-bundler/conjureircli/inte
github.com/palantir/godel/pkg/products/v2
# github.com/palantir/pkg v1.0.1
github.com/palantir/pkg
# github.com/palantir/pkg/bearertoken v1.0.1
# github.com/palantir/pkg/bearertoken v1.0.2-0.20211018212129-dd668d3dcdb4
## explicit
github.com/palantir/pkg/bearertoken
# github.com/palantir/pkg/binary v1.0.1
Expand Down