Skip to content

[DateInput]: Remove defaultProps and consolidate datetime constants #7516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

[DateInput]: Remove defaultProps and consolidate datetime constants #7516

wants to merge 2 commits into from

Conversation

ggdouglas
Copy link
Contributor

@ggdouglas ggdouglas commented Jul 25, 2025 •
edited
Loading

Part of #7518

  • Replaces defaultProps on DateInput in favor of ES6 default parameters.
  • Also consolidates datetime constant values to be reused as default values across datetime components.
  • Removes DateInputPropsWithDefaults type.

@svc-palantir-github
Copy link

Move remaining datetime constants to single constants file

Build artifact links for this commit: documentation | landing | table | demo

This is an automated comment from the deploy-preview CircleCI job.

@ggdouglas ggdouglas changed the title Remove DateInput.defaultProps and consolidate datetime constants [DateInput] Remove defaultProps and consolidate datetime constants Jul 25, 2025
@ggdouglas ggdouglas changed the title [DateInput] Remove defaultProps and consolidate datetime constants [DateInput]: Remove defaultProps and consolidate datetime constants Jul 25, 2025
@ggdouglas ggdouglas mentioned this pull request Jul 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
no changelog Package: datetime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggdouglas @svc-palantir-github