Undo PRs #9 and #10 #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 6, 2014 12:27
The topic interface should be favored, and there's already a reference controller implementation in pal_ros_controllers/current_limit_controller.
The message in pal_control_msgs/ActuatorCurrentLimit is favored because: - It has correct semantics, we are limiting _actuator_ currents, not _joint_ currents. - It allows to independently limit multiple actuators.
|
Any idea of what code was using these two PRs? |
|
I could only find two references:
|
|
@adolfo-rt before you spend a lot of time on writing an rqt plugin, check with @hilario, he wrote a dynamic-dynamic-reconfigure, that allows you to define the parameters at runtime, and thus to use the rqt_reconfigure interface with all the benefits of a dynamic plugin. |
|
FYI, I plan to merge this one tomorrow afternoon (Sept 3). |
|
The code that was using this has already been changed to your new version ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11 for the discussion motivating this change.