Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Task App. By Joe Reich #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

sjreich
Copy link

@sjreich sjreich commented Dec 11, 2015

Narrated by the author.

@jaybobo
Copy link
Member

jaybobo commented Dec 14, 2015

Hey @sjreich you may to @ mention a few of us in your PR comment so that we can offer up some code review. its easy for mentors to overlook PRs if they're not getting an email notification

end

def create
@task = Task.new(task_params)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♨️ hot

@sjreich
Copy link
Author

sjreich commented Dec 14, 2015

I skipped the show page, if that's what you mean. I was concentrating on doing a smooth job on the things I needed practice on.

@paradime
Copy link

Well your app isn't necessarily the only thing that will consume your API.
This is the purpose of the restful app. If I want a ride singular (let's
say in json format) I should be able to sent a get request with an item in
the parameter and get back a json or csv pr html representation of your
object. This is something that you wouldn't think about because we only
expect our own apps to consume our API (aka, your Controller routes).
On Dec 14, 2015 4:40 PM, "Joe Reich" [email protected] wrote:

I skipped the show page, if that's what you mean. I was concentrating on
doing a smooth job on the things I needed practice on.


Reply to this email directly or view it on GitHub
#1 (comment).

@sjreich
Copy link
Author

sjreich commented Dec 15, 2015

I'm not sure I understand. Maybe we can chat tomorrow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants