looks good #118
Open
looks good #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjreich
reviewed
May 24, 2019
| @@ -1,26 +1,26 @@ | |||
|
|
|||
| def capitalize_each_string(input) | |||
| #implement your solution here | |||
| input.map {|i| i.capitalize} | |||
There was a problem hiding this comment.
This is a good case for the &:capitalize syntax.
sjreich
reviewed
May 24, 2019
| end | ||
|
|
||
| def fetch_the_first_two(input) | ||
| #implement your solution here | ||
| input.take(2) |
There was a problem hiding this comment.
Works. input.first(2) is probably a bit more idiomatic.
sjreich
reviewed
May 24, 2019
| end | ||
|
|
||
| def fetch_CD_animals(input) | ||
| #implement your solution here | ||
| input.grep(/\Ac|\Ad/) |
There was a problem hiding this comment.
nice case for a regex. Maybe /\A[cd]/?
Check out the ruby string methods, though, and see if you can find one that is fine-tuned for this scenario?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perhaps