Word Count Solution(Shabbir Saifee) #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaybobo
requested changes
Feb 22, 2018
| @@ -0,0 +1,21 @@ | |||
| #Generates the count of each word in the file sorted by the maximum occured word first | |||
| def wordCount | |||
There was a problem hiding this comment.
why not a more object oriented solution?
| def wordCount | ||
| file = File.open("speech.txt") | ||
|
|
||
| words = file.read().downcase().split(/\W+/) |
There was a problem hiding this comment.
| file = File.open("speech.txt") | ||
|
|
||
| words = file.read().downcase().split(/\W+/) | ||
| words_map = {} |
There was a problem hiding this comment.
Anytime you instantiate an empty collection in order to iteratively build it up is a good clue that you should probably look to use a method like .map or .reduce
| if words_map.has_key?(word) | ||
| words_map[word] += 1 | ||
| else | ||
| words_map[word] = 1 |
There was a problem hiding this comment.
Hash.new lets you set default values.
https://ruby-doc.org/core-1.9.3/Hash.html
| #words_map.sort {|x,y| y[1] <=> x[1]} -- 12.3s | ||
| #words_map.sort_by {|k,v| -v} -- 5.9s | ||
| #words_map.sort_by {|k,v| v}.reverse -- 3.7 | ||
| puts words_map.sort_by {|k,v| v}.reverse.to_h |
There was a problem hiding this comment.
Whether you go for a more functional or OOP approach; consider SRP in order to improve readability and maintability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jaybobo