fix(consensus): send decided vote for past round

pactus-project · Nov 30, 2024 · 66b7953 · 66b7953
1 parent 8ad18ad
commit 66b7953
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/consensus/consensus.go b/consensus/consensus.go
@@ -508,14 +508,13 @@ func (cs *consensus) HandleQueryVote(height uint32, round int16) *vote.Vote {
 	votes := []*vote.Vote{}
 	switch {
 	case round < cs.round:
-		// A validator requests votes for past rounds.
-		// Sending cp:decide for the last round helps them advance to the current round.
-		vs := cs.log.CPDecidedVoteSet(cs.round - 1)
+		// Past round: Only broadcast cp:decided votes
+		vs := cs.log.CPDecidedVoteSet(round)
 		votes = append(votes, vs.AllVotes()...)
 
 	case round == cs.round:
 		// Current round
-		m := cs.log.RoundMessages(cs.round)
+		m := cs.log.RoundMessages(round)
 		votes = append(votes, m.AllVotes()...)
 
 	case round > cs.round: