Fix git access token not being sent in header #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidates a lot of repeated checks when accessing json object strings into a local method of its own
Change run tasks' working directory from project directory to <build_directory>/test-project
Git only accepts auth tokens passed in the header
|
Looks like this was packwiz/packwiz-installer#49 Just found it after doing all of this lol. It was a good little exercise though so oh well! Shouldn't hurt to accept it before you move to your maven repo. |
|
Thanks for the PR! I'll definitely merge this - I ought to have merged the previous PR that also did this but I thought the rewrite would take less time than it has :P I definitely should push my progress somewhere, hopefully I can get the rewrite finished fairly soon. |
comp500
requested changes
Mar 6, 2023
src/main/java/link/infra/packwiz/installer/bootstrap/Bootstrap.java
Outdated
Show resolved
Hide resolved
|
Yeah. I'd love to see it. I'm getting more invested on working on it more
as I've been looking through the code more and more, but I'm a little
hesitant because it sounds like you've got big stuff in the works.
…On Mon, Mar 6, 2023 at 11:31 AM comp500 ***@***.***> wrote:
Thanks for the PR! I'll definitely merge this - I ought to have merged the
previous PR that also did this
<#5> but I
thought the rewrite would take less time than it has :P
I definitely should push my progress somewhere, hopefully I can get the
rewrite finished fairly soon.
—
Reply to this email directly, view it on GitHub
<#8 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJSAF4F2CL5CPSMQV5GLSDW2Y3RLANCNFSM6AAAAAAVQMWKZA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
is there any releases or prebuilt binary with this patch available? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in latest (v0.0.3). Github API began complaining about needing the tokens to be passed in the request header, which of course, stops packwiz dead in its tracks if you've passed a token in.
Typically, these authorization header tokens are done with "Authorization" as the key name, which worked when I tested it.
In addition, I did some minor cleanup for readability and maintainability.
Last, but not least, I setup the
applicationGradle plugin to run results in a new build subfolder<gradle_build_dir>/test-projectwhere the default is<project_dir>/build/test-project.