CI: Test on several Bazel and Ubuntu versions. #521
+70
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smolkaj
force-pushed
the
ci
branch
3 times, most recently
from
2b388bf to
876ea89
Compare
Also makes some improvements to the CI script taken from https://github.com/google/netkat. They will allow us to make better use of the cache while avoiding hitting GitHub's cache limits. Signed-off-by: Steffen Smolka <[email protected]>
|
This is now ready for review, @jonathan-dilorenzo and @chrispsommers. |
| strategy: | ||
| matrix: | ||
| # We only test on the oldest version we want to support and latest. | ||
| # We trust that things also work for versions in the middle. |
There was a problem hiding this comment.
That's brave ;)
There was a problem hiding this comment.
A lot less brave than what we have today, which is to only test a single version.
jonathan-dilorenzo
approved these changes
Dec 18, 2024
|
FYI: Since this is changing the name of some checks, we need to bypass branch protections to submit and/or update our branch protections rules (probably afterwards). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also makes some improvements to the CI script taken from https://github.com/google/netkat.
They will allow us to make better use of the cache while avoiding hitting GitHub's cache limits.