Modernize: Use std::filesystem::path for p4includePath #5470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDodd
reviewed
Jan 29, 2026
atta-ullah01
force-pushed
the
fix/cpp20-modernization
branch
2 times, most recently
from
3b32f69 to
7a6bb25
Compare
Signed-off-by: Attaullah Ansari <[email protected]>
atta-ullah01
force-pushed
the
fix/cpp20-modernization
branch
from
7a6bb25 to
23ed3f7
Compare
atta-ullah01
changed the title
fruffy
reviewed
Jan 30, 2026
frontends/p4/toP4/toP4.cpp
Outdated
| if (includesEmitted.find(sourceFile) == includesEmitted.end()) { | ||
| if (sourceFile.startsWith(p4includePath)) { | ||
| const char *p = sourceFile.c_str() + strlen(p4includePath); | ||
| if (sourceFile.startsWith(p4includePath.generic_string().c_str())) { |
Collaborator
There was a problem hiding this comment.
You could probably convert sourcefile to a path too, should make this easier. If we are already modernizing we could also clean up the toP4 usage of files.
Author
There was a problem hiding this comment.
Done! Added a commit using std::filesystem::relative() for the include path handling in toP4.
Collaborator
There was a problem hiding this comment.
Thanks. Let's convert sourceFile to std::filesystem::path also, then we should be done.
Signed-off-by: Attaullah Ansari <[email protected]>
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces C-string path handling with std::filesystem::path.
Key Changes
Path Handling:
p4includePathandp4_14includePathtostd::filesystem::path/)strdupusage in tests