This repository was archived by the owner on Aug 26, 2022. It is now read-only.
Open
Conversation
Contributor
|
Personally, I would have not added a bool to GetNext. Instead, just check the operation type inside the cycledetector strategy. Unless there is an issue with doing this? BugFindingRuntime.cs has essentially no changes, so should be reverted (unless GitHub is just not showing them). When I tried to make this change, I struggled because the cycle detector uses the trace of operations and it assumes that trace.count - 2 (or something like that) will be the last operation and that this operation has a state hash. But this is no longer the case. I think you will need to take this into account. This was my attempt: |
Contributor
|
Thanks guys! I will check these stuff out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for cycles only at Sends