[4/n] [reconfigurator-planning] add a way to set the target release at system creation time #8939
+445
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
jgallagher
approved these changes
Aug 28, 2025
| bail!("output path `{output_path}` already exists"); | ||
| } | ||
|
|
||
| // Just use a fixed key for now. |
There was a problem hiding this comment.
Do we need to use a fixed key? (Could we let tufaceous generate a random one?)
There was a problem hiding this comment.
This is a bit dumb but if you don't specify a key, tufaceous outputs the key that was produced, making the output unstable 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work in #8726, updates will only happen if all zones are at known versions before the update starts. In tests, the easiest way to achieve this is to start off the
ExampleSystemwith a target release at creation time.This PR:
0.0.1fake manifest that tests can useIn order to do this, the
ExampleSystemBuildernow needs to be aware of how to extract TUF repos. Reconfigurator-cli already had code to create and extract TUF repos, which I've moved into nexus-reconfigurator-planning.This is going to run into issues with Cosmo boards since they'll have multiple host phase 1 artifacts -- added TODOs to flag that.
Depends on: